rpcd and menu file do not support OR.Īnother changes have to be made inside function of file in lici-base that retrieves firewall's helpers. Why not make luci-app-firewall support both, fw3 and fw4? That's quite difficult as well, as both are depending on rcpd acl and menu, where items showing up in interface depend on existence of binary, which is in fw3: /sbin/fw3 and in fw4: /usr/sbin/fw4, later also makes a symlink /usr/sbin/fw3 -> fw4 for compatibility, but this won't help as path must also remain same. I also tried to make a variant in another file, that unfortunately won't work either. It seems to be quite impossible to build a luci package with variant option while using luci.mk and I am quite sure that it isn't acceptable that I tear down a luci package and build it like a conventional package. Helper file’s location could be worked out on a lua file making it support both locations. Other way ofcourse would be to change fw3 link’s location in fw4, but I’d rather loose that link there completely separating these packages completely from each other. So let me know your opinions where this variation should be. That kind of package although might be impossible to archieve, since once of these changes were in a rpcd rule file, which cannot be dynamic afaik. Anyway, my luci-app-firewall at the moment supports fw4 - and changes are not made on running system, changes are on package’s sources so that I can simple build package in my buildroot, if we agree that variant should be on luci’s side - I can easily create a branch for fw4 variant and do a PR - even better would be to support both on a single package, but I wasn’t able to make a depends rules that would had actually worked, although reason for this might had been elsewhere. Pseudos here are since I am bit busy right now and won’t be doing true comparison at the moment.ĪND if I remember correctly, there was also a 3rd similar difference. There’s also a helper file which luci-app-firewall depends on, which assists when simpler firewalling rules are made for applications more or less simpler than creating rules, I’ve never before this even known about this, but just found out about this when studying why luci-app-firewall didn’t show in luci these files are also in different locations, even though it’s paths last directory difference x/x/firewall x/x/firewall4. Fw4 has a fw3 symbolic link, but if I remember correctly, it’s located in /sbin/fw3 in firewall package - when on firewall4, fw4 binary is in /usr/sbin, and so is symbolic link fw3, so even though applications are compatible between each other, changes have to be made to either, firewall4 or luci-app-firewall or by making variant luci-app-firewall4 provididng luci-app-firewall.
0 Comments
Leave a Reply. |